Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clears table after contribution #612

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Clears table after contribution #612

merged 2 commits into from
Oct 12, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 11, 2018

Resolves brave/brave-browser#1501

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc requested a review from petemill October 11, 2018 20:28
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. One problem I had was that contributions would go through and BAT was deducted even if no sites were listed in auto-contribute table. Will create follow up.

@jasonrsadler jasonrsadler merged commit bd5e9f8 into master Oct 12, 2018
@jasonrsadler jasonrsadler deleted the clear-table branch October 12, 2018 02:25
jasonrsadler pushed a commit that referenced this pull request Oct 12, 2018
Clears table after contribution
jasonrsadler pushed a commit that referenced this pull request Oct 12, 2018
Clears table after contribution
@jasonrsadler
Copy link
Contributor

master: bd5e9f8
0.55: 348bf12
0.56: 9c4d64a

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Update crash reporting label to remove reference to "statistics"
petemill pushed a commit that referenced this pull request Jul 27, 2020
Update crash reporting label to remove reference to "statistics"
petemill pushed a commit that referenced this pull request Jul 28, 2020
Update crash reporting label to remove reference to "statistics"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear table after contribution
3 participants