Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadyCallback should be a repeating callback (uplift to 1.11.x) #5866

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 16, 2020

Uplift of #5847
fix brave/brave-browser#10271

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team June 16, 2020 18:42
@brave-builds brave-builds self-assigned this Jun 16, 2020
@brave-builds brave-builds added this to the 1.11.x - Beta milestone Jun 16, 2020
@kjozwiak
Copy link
Member

Looks like test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-pr5847_issues-10271_1.11.x/1/execution/node/417/log/.

15:40:58  1 test crashed:
15:40:58      BraveRewardsBrowserTest.AutoContributionMultiplePublishersUphold (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:1855)

However, seems like an intermittent issue and not related to this specific PR.

test-install also failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pr5847_issues-10271_1.11.x/1/execution/node/646/log/. However, this is a known issue and doesn't block uplift as it's not related to this particular PR.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #5847 (comment).

@kjozwiak kjozwiak merged commit f6ba12b into 1.11.x Jun 24, 2020
@kjozwiak kjozwiak deleted the pr5847_issues/10271_1.11.x branch June 24, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants