Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome page spinner #580

Merged
merged 2 commits into from
Oct 8, 2018
Merged

Welcome page spinner #580

merged 2 commits into from
Oct 8, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 8, 2018

Resolves brave/brave-browser#1099
Resolves brave/brave-browser#1297
Resolves brave/brave-browser#1420

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • enable rewards
  • make sure that spinner is shown until wallet is created
  • clean profile
  • enable rewards
  • claim grant
  • make sure that total is not in wallet summary

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Oct 8, 2018
@NejcZdovc NejcZdovc requested a review from jasonrsadler October 8, 2018 16:54
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome work! ++

@jasonrsadler jasonrsadler merged commit 45a5c4c into master Oct 8, 2018
@NejcZdovc NejcZdovc deleted the welcome-spinner branch October 8, 2018 17:06
jasonrsadler pushed a commit that referenced this pull request Oct 8, 2018
jasonrsadler pushed a commit that referenced this pull request Oct 8, 2018
@jasonrsadler
Copy link
Contributor

master: 45a5c4c
0.55.x: f9df287
0.56.x: efcf571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants