-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable geolocation in Tor profiles #571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e12ddd5
to
7e54a33
Compare
Got some existing errors / time out when running unit tests and browser tests, but is unrelated to this change. |
bbondy
previously approved these changes
Oct 4, 2018
7e54a33
to
b9f2fcc
Compare
bbondy
approved these changes
Oct 4, 2018
darkdh
approved these changes
Oct 4, 2018
yrliou
added a commit
that referenced
this pull request
Oct 4, 2018
Disable geolocation in Tor profiles
yrliou
added a commit
that referenced
this pull request
Oct 4, 2018
Disable geolocation in Tor profiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#1353
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Manual test:
Unit test:
npm test brave_unit_tests -- --filter=BraveHostContentSettingsMapTest.*
Reviewer Checklist: