Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable geolocation in Tor profiles #571

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Disable geolocation in Tor profiles #571

merged 2 commits into from
Oct 4, 2018

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 4, 2018

Fix brave/brave-browser#1353

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Manual test:

  1. Visit https://browserleaks.com/geo in a normal window, will get a geolocation permission prompt.
  2. Visit https://browserleaks.com/geo in a Tor window, result should be as below without any prompt:

screen shot 2018-10-04 at 11 06 38 am

Unit test:
npm test brave_unit_tests -- --filter=BraveHostContentSettingsMapTest.*

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@yrliou yrliou self-assigned this Oct 4, 2018
@yrliou yrliou force-pushed the disable_geo_prompt branch 2 times, most recently from e12ddd5 to 7e54a33 Compare October 4, 2018 20:28
@yrliou yrliou changed the title WIP: Disable geolocation in Tor profiles Disable geolocation in Tor profiles Oct 4, 2018
@yrliou
Copy link
Member Author

yrliou commented Oct 4, 2018

Got some existing errors / time out when running unit tests and browser tests, but is unrelated to this change.

@yrliou yrliou requested review from darkdh and bbondy October 4, 2018 20:34
bbondy
bbondy previously approved these changes Oct 4, 2018
@yrliou yrliou merged commit 058d51a into master Oct 4, 2018
yrliou added a commit that referenced this pull request Oct 4, 2018
Disable geolocation in Tor profiles
yrliou added a commit that referenced this pull request Oct 4, 2018
Disable geolocation in Tor profiles
@yrliou
Copy link
Member Author

yrliou commented Oct 4, 2018

master: 058d51a
0.56.x: 061c72e
0.55.x: 5d22b1f

@yrliou yrliou deleted the disable_geo_prompt branch October 4, 2018 21:43
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Upgrade to Chromium 68
petemill pushed a commit that referenced this pull request Jul 27, 2020
Upgrade to Chromium 68
petemill pushed a commit that referenced this pull request Jul 28, 2020
Upgrade to Chromium 68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geolocation prompt is not blocked on Tor Windows
3 participants