Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bottom toolbar buttons highlighting on toolbar click #5557

Merged
merged 2 commits into from
May 15, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented May 14, 2020

Resolves brave/brave-browser#8460

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 14, 2020
@samartnik samartnik added this to the 1.11.x - Nightly milestone May 14, 2020
@samartnik samartnik requested a review from SergeyZhukovsky May 14, 2020 19:36
@samartnik samartnik self-assigned this May 14, 2020
@samartnik samartnik force-pushed the android_button_glitch_bottom_toolbar branch from 9ae3e6f to ac6a3bb Compare May 14, 2020 23:29
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.11.5

  • Verified tapping next to the button on bottom toolbar doesn't highlight the bookmark button
  • Veriied tapping on bottom bar in tab tray view doesn't highlight the bookmark button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Bookmark button gets selected when tapped next to menu button
3 participants