Fixes converted ads keep showing

[tmancey]

Resolves brave/brave-browser#9436

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

See brave/brave-browser#9436

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[NejcZdovc]

double const?

[tmancey]

const X* const p means "p is a const pointer to an X that is const": you can’t change the pointer p itself, nor can you change the X object via p.

[tmancey]

@NejcZdovc see https://isocpp.org/wiki/faq/const-correctness#const-ptr-vs-ptr-const

[NejcZdovc]

code looks good to me, didn't test out functionality of it

[moritzhaller]

lgtm! (focussed mainly on logic, did not run tests locally)

[btlechowski]

LGTM

Brave	1.10.28 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)
Revision	3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS	Linux

Verified test plan from brave/brave-browser#9436.
Also checked the logs for creativeSetId (...) has exceeded the frequency capping for conversions message.
Verified ads from the same creativeSetId were not shown after conversion.

[6080:1:0505/010858.182044:INFO:ads_impl.cc(359)] Browser state changed to unidle
[6080:1:0505/010858.204730:INFO:ads_impl.cc(954)] Serving ad from categories:
[6080:1:0505/010858.204876:INFO:ads_impl.cc(956)]   technology & computing-technology & computing
[6080:1:0505/010858.205649:INFO:ads_impl.cc(956)]   arts & entertainment-video games
[6080:1:0505/010858.205814:INFO:ads_impl.cc(956)]   technology & computing-software
[6080:1:0505/010858.207833:INFO:ads_impl.cc(974)] No eligible ads found in categories:
[6080:1:0505/010858.210006:INFO:ads_impl.cc(976)]   technology & computing-technology & computing
[6080:1:0505/010858.216231:INFO:ads_impl.cc(976)]   arts & entertainment-video games
[6080:1:0505/010858.216346:INFO:ads_impl.cc(976)]   technology & computing-software
[6080:1:0505/010858.216469:INFO:ads_impl.cc(1007)] Serving ad from parent categories:
[6080:1:0505/010858.216551:INFO:ads_impl.cc(1009)]   technology & computing
[6080:1:0505/010858.216631:INFO:ads_impl.cc(1009)]   arts & entertainment
[6080:1:0505/010858.231964:INFO:ads_impl.cc(1188)] All advertisers have been shown, so round robin
[6080:1:0505/010858.234288:INFO:client.cc(420)] Resetting seen advertisers
[6080:1:0505/010858.234825:INFO:ads_impl.cc(1130)] creativeSetId de5a82e1-17d6-47e0-a368-17f8f56dfeb3 has exceeded the frequency capping for conversions
[6080:1:0505/010858.235719:INFO:ads_impl.cc(974)] No eligible ads found in categories:
[6080:1:0505/010858.235923:INFO:ads_impl.cc(976)]   technology & computing
[6080:1:0505/010858.236101:INFO:ads_impl.cc(976)]   arts & entertainment
[6080:1:0505/010858.236275:INFO:ads_impl.cc(1020)] Serving ad notification from untargeted category
[6080:1:0505/010858.243086:INFO:client.cc(593)] Successfully saved client state
[6080:1:0505/010858.243522:INFO:ads_impl.cc(1080)] Notification not made: No eligible ads found

Verified that without conversion, ads keep showing for the same creative set