Code

Binance version 2 trading widget#5160

Code

Merged

ryanml merged 60 commits intomasterbrave/brave-core:masterfrom binance-version-2brave/brave-core:binance-version-2Copy head branch name to clipboardApr 10, 2020

+6,827-53

Commits

Commits on Apr 9, 2020

• Initial NTP widget with buy support

  ryanml

  committed
  dc115fc

  Copy full SHA for dc115fc

• Adding front-end resources for full widget

  ryanml

  committed
  4c354c2

  Copy full SHA for 4c354c2

• Adding backend API, controller, service

  ryanml

  committed
  9aa0fd3

  Copy full SHA for 9aa0fd3

• Adding PKCE code challenge store

  ryanml

  committed
  2ed0595

  Copy full SHA for 2ed0595

• Adding account balance retrieval, json parser tests

  ryanml

  committed
  953a7ea

  Copy full SHA for 953a7ea

• Adding conversion quote endpoint

  ryanml

  committed
  887f80b

  Copy full SHA for 887f80b

• Adding V1 API code, TickerPrice and Volume endpoints

  ryanml

  committed
  4270169

  Copy full SHA for 4270169

• Collapse BinanceController into BinanceService

  

  bbondy

  authored and

  ryanml

  committed
  8ddd979

  Copy full SHA for 8ddd979

• Return correct success boolean

  

  bbondy

  authored and

  ryanml

  committed
  c51f636

  Copy full SHA for c51f636

• Add BAT to currency lookup table and create a fallback

  

  bbondy

  authored and

  ryanml

  committed
  33f80ef

  Copy full SHA for 33f80ef

• Fixup where Binance buildflags

  

  bbondy

  authored and

  ryanml

  committed
  f3f84ff

  Copy full SHA for f3f84ff

• Fix oauth flow w/ binance: protocol handler

  Show description for 47e852b
  

  bbondy

  authored and

  ryanml

  committed
  47e852b

  Copy full SHA for 47e852b

• Fix missing dep on some buildflags

  Show description for 3f3a22f
  

  bbondy

  authored and

  ryanml

  committed
  3f3a22f

  Copy full SHA for 3f3a22f

• Use build config for client and secret

  

  bbondy

  authored and

  ryanml

  committed
  b1a019e

  Copy full SHA for b1a019e

• Update callback url to com.brave.binance scheme

  

  bbondy

  authored and

  ryanml

  committed
  de5556d

  Copy full SHA for de5556d

• Fixup PKCE flow and param encoding

  

  bbondy

  authored and

  ryanml

  committed
  4e562ce

  Copy full SHA for 4e562ce

• Handle code challenge and verifier on C++ side

  

  bbondy

  authored and

  ryanml

  committed
  a1d2476

  Copy full SHA for a1d2476

• Fixing namespace, pref registry

  ryanml

  committed
  ab59677

  Copy full SHA for ab59677

• Use GET method for user balance

  Show description for f2ee207
  

  bbondy

  authored and

  ryanml

  committed
  f2ee207

  Copy full SHA for f2ee207

• Remove binance_client_secret

  Show description for 7b703f3
  

  bbondy

  authored and

  ryanml

  committed
  7b703f3

  Copy full SHA for 7b703f3

• Front-end re-organization, lint fixes

  ryanml

  committed
  7f46eea

  Copy full SHA for 7f46eea

• Removing Connect flow for US users

  ryanml

  committed
  f262184

  Copy full SHA for f262184

• wiring in asset volume, values in USD, BTC

  ryanml

  committed
  ceb4010

  Copy full SHA for ceb4010

• Networking for user deposit info (address, url), wiring

  ryanml

  committed
  d5e1eae

  Copy full SHA for d5e1eae

• Finishing remaining backend for conversions

  Show description for 8842356
  ryanml

  committed
  8842356

  Copy full SHA for 8842356

• Fix invalid Binance oauth scope

  

  bbondy

  authored and

  ryanml

  committed
  a2d993e

  Copy full SHA for a2d993e

• Front end cleanup, price and ticker fixes

  ryanml

  committed
  5c2efc2

  Copy full SHA for 5c2efc2

• Adding QR code view + address copy

  ryanml

  committed
  48f882a

  Copy full SHA for 48f882a

• Using just asset address for QR code, small formatting fixes

  ryanml

  committed
  66fc997

  Copy full SHA for 66fc997

• Adding convert asset lookup table, grabbing convert quote + timeout

  ryanml

  committed
  1d75e30

  Copy full SHA for 1d75e30

• Adding wiring for final conversion step

  ryanml

  committed
  1de0ab9

  Copy full SHA for 1de0ab9

• Index render refactor

  ryanml

  committed
  0e66d3a

  Copy full SHA for 0e66d3a

• Localization, bug fixes

  ryanml

  committed
  a48c3b3

  Copy full SHA for a48c3b3

• Removing unused function

  ryanml

  committed
  dedd323

  Copy full SHA for dedd323

• Fixing invalid quote parameter, retyping

  ryanml

  committed
  3ca88ff

  Copy full SHA for 3ca88ff

• Setting convert expiry time to 30 seconds

  Show description for f7b194f
  ryanml

  committed
  f7b194f

  Copy full SHA for f7b194f

• Using full asset list for convert from

  ryanml

  committed
  0ddbf2f

  Copy full SHA for 0ddbf2f

• Modifying baseAsset value, including extra currencies in list

  ryanml

  committed
  5adf8db

  Copy full SHA for 5adf8db

• Adding invalid token/reconnect flow

  ryanml

  committed
  922d33a

  Copy full SHA for 922d33a

• Not using URL query for convert confirm request

  ryanml

  committed
  1cc4fe3

  Copy full SHA for 1cc4fe3

• Last minute display tweaks

  ryanml

  committed
  82da535

  Copy full SHA for 82da535

• Improved error handling for crypto conversions

  ryanml

  committed
  74f5ed7

  Copy full SHA for 74f5ed7

• Updating binance_enabled build flag

  Show description for c2869b0
  ryanml

  committed
  c2869b0

  Copy full SHA for c2869b0

• Addressing code review comments

  ryanml

  committed
  f6844ad

  Copy full SHA for f6844ad

• Displaying total account balance in BTC, total USD value

  Show description for 04949e8
  ryanml

  committed
  04949e8

  Copy full SHA for 04949e8

• Hiding dropdowns when clicking outside of them

  ryanml

  committed
  a6e9551

  Copy full SHA for a6e9551

• Adding guard for migration, don't rely on accountBalances in buyView

  ryanml

  committed
  5c0fb48

  Copy full SHA for 5c0fb48

• Fixing test build, NaN BTC value, migration path

  ryanml

  committed
  e84402b

  Copy full SHA for e84402b

• Listing accounts with balances at the top

  ryanml

  committed
  f245bbe

  Copy full SHA for f245bbe

• Hiding balance by default, re-fetching clientURL on disconnect

  ryanml

  committed
  68622b7

  Copy full SHA for 68622b7

• Fixes brave/brave-browser#9079 - Removes duplicate binance toggle entry

  ryanml

  committed
  cef6edd

  Copy full SHA for cef6edd

• Addressing review feedback

  ryanml

  committed
  96316bc

  Copy full SHA for 96316bc

• Moving connect button from header, disconnect action to widget menu

  ryanml

  committed
  fa40f54

  Copy full SHA for fa40f54

• Implement review feedback

  

  bbondy

  authored and

  ryanml

  committed
  596cb27

  Copy full SHA for 596cb27

• Make sure no API access in extensions

  

  bbondy

  authored and

  ryanml

  committed
  3972d72

  Copy full SHA for 3972d72

• Add Binance service tests for all APIs

  

  bbondy

  authored and

  ryanml

  committed
  06048c5

  Copy full SHA for 06048c5

• Moving data update actions to newTab, refresh action in menu

  ryanml

  committed
  cb730fc

  Copy full SHA for cb730fc

• Fixing bug where new NTP pages show un-authed view

  ryanml

  committed
  1d7fea7

  Copy full SHA for 1d7fea7

Commits on Apr 10, 2020

• Reordering nav menu, fixing widget menu persistence

  ryanml

  committed
  8f64a15

  Copy full SHA for 8f64a15

• Add and use API to revoke token

  bbondy

  committed
  74c48b1

  Copy full SHA for 74c48b1