Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send guid or env with crash reports #5065

Merged
merged 2 commits into from
Mar 26, 2020
Merged

don't send guid or env with crash reports #5065

merged 2 commits into from
Mar 26, 2020

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Mar 25, 2020

Resolves brave/brave-browser#8865

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bridiver bridiver requested a review from fmarier March 25, 2020 22:59
@bridiver bridiver self-assigned this Mar 25, 2020
@bridiver
Copy link
Collaborator Author

unfortunately all of this stuff happens deep within crashpad/breakpad so I couldn't really avoid patching


WinVMSize ProcessSnapshotWin::DetermineSizeOfEnvironmentBlock(
WinVMAddress start_of_environment_block) {
+ return 0;
Copy link
Collaborator Author

@bridiver bridiver Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AddMemorySnapshot(
      process_parameters.Environment,
      DetermineSizeOfEnvironmentBlock(process_parameters.Environment),
      &extra_memory_);
void ProcessSnapshotWin::AddMemorySnapshot(
    WinVMAddress address,
    WinVMSize size,
    std::vector<std::unique_ptr<internal::MemorySnapshotGeneric>>* into) {
  if (size == 0)
    return;
  ...

@bridiver bridiver changed the title Issues/8865 don't send guid or env with crash reports Mar 25, 2020
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should uplift too.

@bridiver bridiver merged commit c842c83 into master Mar 26, 2020
@bridiver bridiver deleted the issues/8865 branch March 26, 2020 03:43
@bsclifton bsclifton added this to the 1.8.x - Release milestone May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash reports contain guid and env
3 participants