-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't build brave_settings_import_data_handler on Android #4711
Conversation
@@ -176,10 +177,6 @@ source_set("ui") { | |||
sources += [ | |||
"webui/settings/brave_settings_import_data_handler_mac.mm", | |||
] | |||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this entire block needs to move up to https://github.com/brave/brave-core/pull/4711/files#diff-4298e412eb456ad3ceed2346abb95f6aR99 to avoid building brave_settings_import_data_handler.cc in macos
30175a1
to
ab29c05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
ab29c05
to
dbb6a25
Compare
dbb6a25
to
601428b
Compare
Updated to add missing milestone to both this and brave/brave-browser#8356 |
Resolves brave/brave-browser#8356
Issue introduced by #4530
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.