Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TOS links #4625

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fixes TOS links #4625

merged 1 commit into from
Feb 13, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 13, 2020

Resolves brave/brave-browser#8229

Submitter Checklist:

Test Plan:

  • open browser
  • make sure that link is correct now on rewards page and panel

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.6.x - Nightly milestone Feb 13, 2020
@NejcZdovc NejcZdovc self-assigned this Feb 13, 2020
@NejcZdovc NejcZdovc requested review from ryanml and a team and removed request for ryanml February 13, 2020 06:27
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nit is I think we should have a file like rewards-urls.ts that spits out something like:

export {
  batTos: 'https://basicattentiontoken.org/user-terms-of-service',
  ...otherURLConstants
}

That way we can manage URLs in one place, otherwise lgtm

@NejcZdovc
Copy link
Contributor Author

CI failed on test-install, not related to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical linking issue for BR
3 participants