Fixed brave scheme url is changed to chrome scheme url when copying from omnibox #4512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Feb 5, 2020
darkdh
approved these changes
Feb 6, 2020
|
Kindly ping to owner :) @bridiver |
bridiver
reviewed
Feb 11, 2020
|
|
||
| if (ShouldAdjust(original_selected_text, selected_text)) { | ||
| BraveLocationBarModelDelegate::FormattedStringFromURL(url, &selected_text); | ||
| ReplaceChromeSchemeToBrave(&url); |
There was a problem hiding this comment.
this logic exists in too many places and needs to be consolidated into some kind of utility function
There was a problem hiding this comment.
Most other places are converting from brave to chrome scheme.
but we need to convert from chrome to brave.
bridiver
reviewed
Feb 11, 2020
|
|
||
| namespace { | ||
| // Copied from omnibox_view_views.cc | ||
| constexpr base::Feature kOmniboxCanCopyHyperlinksToClipboard{ |
There was a problem hiding this comment.
why are we copying this? It's completely pointless because we'd have to track upstream changes anyway which is a problem
bridiver
reviewed
Feb 11, 2020
|
|
||
| void BraveOmniboxViewViews::OnAfterCutOrCopy( | ||
| ui::ClipboardBuffer clipboard_buffer) { | ||
| ui::Clipboard* cb = ui::Clipboard::GetForCurrentThread(); |
There was a problem hiding this comment.
we shouldn't be copying this entire method. We only need different behavior the specific case of a chrome:// url
bridiver
reviewed
Feb 11, 2020
| ui::ScopedClipboardWriter scoped_clipboard_writer(clipboard_buffer); | ||
| scoped_clipboard_writer.WriteText(selected_text); | ||
|
|
||
| if (write_url && |
There was a problem hiding this comment.
this feature flag is a problem as per comment above
simonhong
force-pushed
the
fix_1973
branch
2 times, most recently
from
ad624a0 to
c765318
Compare
bridiver
reviewed
Feb 12, 2020
bridiver
reviewed
Feb 12, 2020
bridiver
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#1973
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
npm run test brave_browser_tests -- --filter=BraveOmniboxViewViewsTest*Reviewer Checklist:
After-merge Checklist:
changes has landed on.