Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hyphens in the adblock list directories #4485

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Feb 4, 2020

This change to match the Chromium style does not affect anything
else than the contents of the Brave Adblock component in the
brave://rewards page.

This is a follow-up to 90eb89e
(brave/brave-browser#7176).

Goes with brave/brave-browser#8038.

Submitter Checklist:

Test Plan:

Look at the "Brave Adblock" entry in brave://credits and ensure it looks mostly the same as before. There will be some ordering changes and some hyphens are now underscores.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier requested a review from bridiver February 4, 2020 03:27
@fmarier fmarier self-assigned this Feb 4, 2020
@fmarier fmarier force-pushed the adblock_lists_underscores branch 2 times, most recently from a6da883 to ec00f27 Compare February 10, 2020 19:58
This change to match the Chromium style does not affect anything
else than the contents of the Brave Adblock component in the
brave://rewards page.

This is a follow-up to 90eb89e
(brave/brave-browser#7176).
@fmarier fmarier force-pushed the adblock_lists_underscores branch from ec00f27 to 7eac687 Compare February 11, 2020 01:47
@fmarier fmarier merged commit ad8f5db into master Feb 12, 2020
@fmarier fmarier deleted the adblock_lists_underscores branch February 12, 2020 00:02
@bbondy bbondy added this to the 1.7.x - Release milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants