Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup some strings for google product names #4475

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 2, 2020

We should not replace google's own product name such as Google Docs
or Google Drive.

fix brave/brave-browser#5450

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

We should not replace google's own product name such as Google Docs
or Google Drive.

fix brave/brave-browser#5450
@simonhong simonhong added this to the 1.5.x - Nightly milestone Feb 2, 2020
@simonhong simonhong self-assigned this Feb 2, 2020
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit fd90db3 into master Feb 3, 2020
@simonhong simonhong deleted the fix_some_strings_for_google_product_name branch February 3, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDFium shows Brave Software Drive in save as pdf modal
2 participants