Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use underscores for sub-directory names (fixes brave/brave-browser#7176) #4380

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jan 16, 2020

Fixes brave/brave-browser#7176.

Requires brave/brave-browser#7748.

Submitter Checklist:

Test Plan:

  1. Open brave://credits.
  2. Verify that the "Brave Local Data" entry is present and that the license text is there too.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier force-pushed the directories-underscore-7176 branch from 62e2626 to 90eb89e Compare January 18, 2020 00:38
@fmarier fmarier merged commit d4f1a50 into master Jan 21, 2020
@fmarier fmarier deleted the directories-underscore-7176 branch January 21, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use underscores in brave/components/third_party/*
2 participants