-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding option to restore excluded pubs #434
Conversation
e293969
to
152d79c
Compare
152d79c
to
e4330ec
Compare
Can you squash commits? |
@jasonrsadler - I can, but the additional commit was an existing issue within the publisher db logic and I wanted to leave it up for visibility. Let me know what you think, thanks! |
No prob. Was going off check off list up top. Leave as is. 👍 |
Do we plan to allow excluding if we have less than 6 publishers? Also, how do we unexclude if we remove publishers to having less than 6. Is that all addressed on a separate issue? |
@jasonrsadler I may have to address this issue in brave-ui, as only the modal has UX for the restore button |
e4330ec
to
44705e2
Compare
@jasonrsadler locales added in to core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing a youtube publisher crashes Brave.
44705e2
to
4453ca8
Compare
@jasonrsadler media publishers should be removable now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!! ++ Works very good! Good job!
|
Adding option to restore excluded pubs
Fixes: brave/brave-browser#936
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Restore
action under the modal titleReviewer Checklist: