Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 79.0.3945.88 to Chromium 79.0.3945.117 (uplift to 1.4) #4322

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 7, 2020

Uplift of #4319
Fixes brave/brave-browser#7640
Related: brave/brave-browser#7648

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade patches from Chromium 79.0.3945.88 to Chromium 79.0.3945.117
@bsclifton bsclifton added this to the 1.4.x - Dev milestone Jan 7, 2020
@bsclifton bsclifton requested a review from a team January 7, 2020 23:46
@bsclifton bsclifton requested a review from bridiver as a code owner January 7, 2020 23:46
@bsclifton bsclifton self-assigned this Jan 7, 2020
@bsclifton bsclifton removed the request for review from bridiver January 7, 2020 23:48
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. CI/Jenkins passed without any issues. Looks like Travis failed as per https://travis-ci.org/brave/brave-core/jobs/634007726?utm_medium=notification&utm_source=github_status. However, this looks like an issue specific to Travis and not related to this specific PR.

@kjozwiak kjozwiak merged commit 7edef73 into 1.4.x Jan 8, 2020
@kjozwiak kjozwiak deleted the bsc-79.0.3945.117-1.4.x branch January 8, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants