Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert cosmetic-filtering-frontend changes which caused GLIBC problem on Linux #4255

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

bsclifton
Copy link
Member

This reverts commit fe9f891, reversing
changes made to 4e6ba95.

Was causing problems specifically on Linux because of the Rust dependency.
This should fix brave/brave-browser#7055
This will un-fix brave/brave-browser#5381

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

This reverts commit fe9f891, reversing
changes made to 4e6ba95.

Was causing problems specifically on Linux because of the Rust dependency.
This should fix brave/brave-browser#7055
This will un-fix brave/brave-browser#5381
@bsclifton bsclifton self-assigned this Dec 18, 2019
@bsclifton bsclifton changed the title Revert "Merge pull request #3303 from brave/cosmetic-filtering-frontend" Revert cosmetic-filtering-frontend changes which caused GLIBC problem on Linux Dec 18, 2019
@bsclifton
Copy link
Member Author

@bridiver did a full local release build on Linux and verified this 👍 Will cancel CI and merge

@bsclifton bsclifton merged commit fcfe38a into master Dec 18, 2019
@bsclifton bsclifton deleted the bsc-revert-cosmetic-filtering branch December 18, 2019 16:50
@bsclifton bsclifton mentioned this pull request Dec 18, 2019
32 tasks
antonok-edm added a commit that referenced this pull request Dec 20, 2019
…ring"

This reverts commit fcfe38a, reversing
changes made to 950778a.
antonok-edm added a commit that referenced this pull request Jan 9, 2020
…ring"

This reverts commit fcfe38a, reversing
changes made to 950778a.
bsclifton pushed a commit that referenced this pull request Jan 9, 2020
…ring"

This reverts commit fcfe38a, reversing
changes made to 950778a.
petemill pushed a commit that referenced this pull request Feb 4, 2020
… block component.

Reverts the revert of the oringal implementation: "Merge pull request #4255 from brave/bsc-revert-cosmetic-filtering"

This reverts commit fcfe38a, reversing
changes made to 950778a.

Fixes some conflicts as a result of master getting flag features and uses updated adblock-rust-ffi version which provides a slightly different API than for the original implementation.
@petemill petemill mentioned this pull request Feb 4, 2020
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C79 bump breaks debug build on Linux Implement cosmetic blocking [tracking]
2 participants