Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes upgrade path for promotions #4038

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fixes upgrade path for promotions #4038

merged 1 commit into from
Nov 20, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 20, 2019

Resolves brave/brave-browser#7021

Submitter Checklist:

Test Plan:

Will test with @mbacchi as he has corrupted profile. Sadly I don't have STR.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 20, 2019
@NejcZdovc NejcZdovc self-assigned this Nov 20, 2019
Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works now for me. Thanks!

@NejcZdovc NejcZdovc merged commit 0342c29 into master Nov 20, 2019
@NejcZdovc NejcZdovc deleted the new-tab-error branch November 20, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in event handler: TypeError: Cannot read property 'find'
2 participants