Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Sync USS Bookmarks #3681

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Disable Sync USS Bookmarks #3681

merged 2 commits into from
Oct 11, 2019

Conversation

AlexeyBarabash
Copy link
Contributor

Fixes brave/brave-browser#6435

Submitter Checklist:

Test Plan:

  1. Get a clean profile
  2. Create bookmark A1.com
  3. Go to brave://sync
  4. Create sync chain and wait

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@darkdh
Copy link
Member

darkdh commented Oct 11, 2019

could you also add this to DisabledFeatures in BraveMainDelegateBrowserTest?

darkdh
darkdh previously approved these changes Oct 11, 2019
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash
Copy link
Contributor Author

CI failed by the reason of

16:58:44  + [ 0.72.94 != 0.72.91 ]
16:58:44  + echo Version mismatch between brave-browser and brave-core in package.json, please try rebasing this branch in brave-core as well 

done rebase

@AlexeyBarabash AlexeyBarabash merged commit 0f4966e into master Oct 11, 2019
@AlexeyBarabash AlexeyBarabash deleted the fix_6435_sync_disable_uss branch October 11, 2019 19:52
mkarolin pushed a commit that referenced this pull request Oct 14, 2019
mkarolin pushed a commit that referenced this pull request Oct 15, 2019
@bsclifton
Copy link
Member

bsclifton commented Oct 16, 2019

Fixed in 0.71.x with #3693
Fixed in 0.70.x with #3695

fmarier pushed a commit that referenced this pull request Oct 29, 2019
Upgrade from Chromium 73.0.3683.67 to Chromium 73.0.3683.75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync failed DCHECK crash on initialization after Chromium update 78
3 participants