Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes twitch for the panel (uplift to 0.69.x) #3308

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 30, 2019

Uplift of #3295

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Aug 30, 2019
@brave-builds brave-builds added this to the 0.69.x - Beta milestone Aug 30, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Only failure under CI/Jenkins is the S3 upload failure which isn't due to this particular PR. CI/Travis passed without any issues. Please make sure that all the correct labels are being used and the appropriate issue is moved into the correct milstone.

@NejcZdovc NejcZdovc merged commit 4479d2b into 0.69.x Aug 31, 2019
@NejcZdovc NejcZdovc deleted the pr3295_fix-twitch_0.69.x branch August 31, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants