Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates 5% cards with anon addresses (uplift to 0.70.x) #3268

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 27, 2019

Uplift of #3267

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Aug 27, 2019
@brave-builds brave-builds added this to the 0.70.x - Dev milestone Aug 27, 2019
@kjozwiak
Copy link
Member

Restarted one more time, received the following:

13:05:56  Cannot contact EC2 (AWS EC2) - android-aws-ci (sir-tpbr9zip): hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
13:18:57  Could not connect to EC2 (AWS EC2) - android-aws-ci (sir-tpbr9zip) to send interrupt signal to process

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.70.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any errors or failures. Please make sure that the correct labels are being used and the appropriate issue is moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit 5cf61a9 into 0.70.x Aug 28, 2019
@NejcZdovc NejcZdovc deleted the pr3267_5-card_0.70.x branch August 28, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants