-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user earns while native Windows and macOS notifications are suppressed #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
added
CI/skip-android
Do not run CI builds for Android
CI/skip-linux
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-ios
Do not run CI builds for iOS
labels
Aug 2, 2019
tmancey
changed the title
[WIP] Fix User Earns While Notifications are Suppressed
[WIP] Fix user earns while native notifications are suppressed
Aug 5, 2019
tmancey
changed the title
[WIP] Fix user earns while native notifications are suppressed
[WIP] Fix user earns while native Windows notifications are suppressed
Aug 5, 2019
tmancey
force-pushed
the
issues/3651
branch
4 times, most recently
from
August 12, 2019 09:11
a6a9bc5
to
a670520
Compare
tmancey
force-pushed
the
issues/3651
branch
9 times, most recently
from
August 23, 2019 14:25
76d048d
to
86cd5af
Compare
tmancey
changed the title
[WIP] Fix user earns while native Windows notifications are suppressed
Fix user earns while native Windows notifications are suppressed
Aug 23, 2019
tmancey
removed
CI/skip-android
Do not run CI builds for Android
CI/skip-ios
Do not run CI builds for iOS
CI/skip-linux
labels
Aug 23, 2019
masparrow
approved these changes
Nov 5, 2019
tmancey
force-pushed
the
issues/3651
branch
2 times, most recently
from
November 5, 2019 10:09
59af5a5
to
5b2fd4a
Compare
tmancey
added
CI/skip-android
Do not run CI builds for Android
CI/skip-ios
Do not run CI builds for iOS
CI/skip-linux
and removed
CI/skip-ios
Do not run CI builds for iOS
CI/skip-android
Do not run CI builds for Android
CI/skip-linux
labels
Nov 5, 2019
tmancey
force-pushed
the
issues/3651
branch
4 times, most recently
from
November 6, 2019 02:33
1618352
to
b313f77
Compare
NejcZdovc
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewards changes looks good
This was referenced Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3651
Requires: #3892
Requires: #3907
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Note: Please test on 32-bit, 64-bit versions of Windows. Please test on all supported versions of Windows. Notifications will always be shown for Chromium Message Center (Brave fallback if native notifications are not supported)
Reviewer Checklist:
After-merge Checklist:
changes has landed on.