Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user earns while native Windows and macOS notifications are suppressed #3084

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 2, 2019

Fixes brave/brave-browser#3651
Requires: #3892
Requires: #3907

Submitter Checklist:

Test Plan:

  • Confirm native Ad notifications are not shown on Windows if Focus Assist is enabled
  • Confirm native Ad notifications are not shown on Windows if notifications are disabled for the user
  • Confirm native Ad notifications are not shown on Windows if notifications are disabled for application
  • Confirm native Ad notifications are not shown on Windows if notifications are disabled by group policy
  • Confirm native Ad notifications are not shown on Windows if notifications are disabled by manifest
  • Confirm native Ad notifications are not shown on macOS 10.15 if notifications set to none
  • Confirm native Ad notifications are not shown on macOS 10.14 and older if notifications set to none
  • Confirm ads are shown if native notifications are set to banner or alert

Note: Please test on 32-bit, 64-bit versions of Windows. Please test on all supported versions of Windows. Notifications will always be shown for Chromium Message Center (Brave fallback if native notifications are not supported)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 2, 2019
@tmancey tmancey added this to the 0.70.x - Nightly milestone Aug 2, 2019
@tmancey tmancey self-assigned this Aug 2, 2019
@tmancey tmancey changed the title [WIP] Fix User Earns While Notifications are Suppressed [WIP] Fix user earns while native notifications are suppressed Aug 5, 2019
@tmancey tmancey changed the title [WIP] Fix user earns while native notifications are suppressed [WIP] Fix user earns while native Windows notifications are suppressed Aug 5, 2019
@tmancey tmancey force-pushed the issues/3651 branch 4 times, most recently from a6a9bc5 to a670520 Compare August 12, 2019 09:11
@tmancey tmancey force-pushed the issues/3651 branch 9 times, most recently from 76d048d to 86cd5af Compare August 23, 2019 14:25
@tmancey tmancey requested a review from kylehickinson as a code owner August 23, 2019 14:25
@tmancey tmancey changed the title [WIP] Fix user earns while native Windows notifications are suppressed Fix user earns while native Windows notifications are suppressed Aug 23, 2019
@tmancey tmancey requested review from bridiver and emerick August 23, 2019 14:34
@tmancey tmancey removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Aug 23, 2019
@tmancey tmancey force-pushed the issues/3651 branch 2 times, most recently from 59af5a5 to 5b2fd4a Compare November 5, 2019 10:09
@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux and removed CI/skip-ios Do not run CI builds for iOS CI/skip-android Do not run CI builds for Android CI/skip-linux labels Nov 5, 2019
@tmancey tmancey modified the milestones: 0.73.x - Dev, 0.74.x - Nightly Nov 5, 2019
@tmancey tmancey force-pushed the issues/3651 branch 4 times, most recently from 1618352 to b313f77 Compare November 6, 2019 02:33
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewards changes looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix user earns while native Windows notifications are suppressed
7 participants