Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave ads mobile delivery policy change #3080

Merged
merged 3 commits into from
Aug 3, 2019
Merged

Brave ads mobile delivery policy change #3080

merged 3 commits into from
Aug 3, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 2, 2019

Fixes brave/brave-browser#5507

Submitter Checklist:

Test Plan:

  • Confirm Ads have not regressed on desktop, i.e. they are delivered as expected (mobile changes cannot be tested until cherry-picked to browser-android-tabs 1.3.0)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

emerick
emerick previously approved these changes Aug 2, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emerick
emerick previously approved these changes Aug 2, 2019
@tmancey tmancey force-pushed the issues/5507 branch 3 times, most recently from 9b4dd9b to 503a6f3 Compare August 2, 2019 15:31
@tmancey tmancey requested a review from emerick August 2, 2019 15:32
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave ads mobile delivery policy change
2 participants