-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Tips for new Twitter site #2943
Conversation
9162bdf
to
d140792
Compare
45b50e4
to
59eef0f
Compare
654a328
to
25ff609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Great team work 🎆
Fixing conflict due to #2723 having just landed... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase, doing now...
components/brave_rewards/resources/extension/brave_rewards/content_scripts/twitter.ts
Show resolved
Hide resolved
25ff609
to
d2e4cc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed the rebase and added functionality to now show the Tip button if we cannot get the tweetId (some Promoted tweets in new twitter).
Since I pushed some code myself, may want to review that too @emerick
…tract enough information from
d2e4cc6
to
a0598fa
Compare
c447533
to
6e61ed8
Compare
Support Tips for new Twitter site
Support Tips for new Twitter site
Fix brave/brave-browser#4548
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
All tests must be run on the old Twitter site and the new Twitter site. All functionality should work when logged in to Twitter and when logged out of Twitter.
Note: You can create a verified Twitter publisher by visiting this special link and following the Twitter flow:
https://publishers-staging.basicattentiontoken.org/publishers/home?twitter=true
Enabling/disabling the Brave Tip icon
Tipping a Twitter user
Reviewer Checklist:
After-merge Checklist:
changes has landed on.