Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download ethereum-remote-client extension and map to brave://wallet #2833

Merged
merged 9 commits into from
Jul 9, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 28, 2019

Fix brave/brave-browser#5117
Fix brave/brave-browser#5118

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy
Copy link
Member Author

bbondy commented Jun 28, 2019

cc FYI @ryanml

@bbondy bbondy force-pushed the brave-wallet-component branch 6 times, most recently from 026c068 to 3d3a7e9 Compare July 3, 2019 13:44
@bbondy bbondy changed the title Download ethereum-remote-client extension Download ethereum-remote-client extension and map to brave://wallet Jul 3, 2019
@bbondy bbondy requested review from bridiver, simonhong and ryanml July 3, 2019 14:33
@bbondy bbondy self-assigned this Jul 3, 2019
@bbondy bbondy added this to the 0.69.x - Nightly milestone Jul 3, 2019
@bbondy bbondy marked this pull request as ready for review July 3, 2019 14:42
@bbondy bbondy force-pushed the brave-wallet-component branch from 2602fa7 to ba88311 Compare July 3, 2019 20:12
@bbondy bbondy added the CI/skip Do not run CI builds (except noplatform) label Jul 4, 2019
@bbondy bbondy force-pushed the brave-wallet-component branch 3 times, most recently from 7a5a72f to fbd6e09 Compare July 5, 2019 13:51
@bbondy bbondy removed the CI/skip Do not run CI builds (except noplatform) label Jul 5, 2019
@bbondy bbondy force-pushed the brave-wallet-component branch 6 times, most recently from 1f543ea to 0ca29fe Compare July 8, 2019 21:04
bridiver
bridiver previously approved these changes Jul 8, 2019
@bbondy
Copy link
Member Author

bbondy commented Jul 9, 2019

Passes on CI for both official and unofficial build types.

@bbondy bbondy merged commit ff9bfe7 into master Jul 9, 2019
@bsclifton bsclifton deleted the brave-wallet-component branch May 12, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants