-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download ethereum-remote-client extension and map to brave://wallet #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc FYI @ryanml |
026c068
to
3d3a7e9
Compare
bbondy
commented
Jul 3, 2019
bbondy
commented
Jul 3, 2019
bbondy
commented
Jul 3, 2019
bridiver
reviewed
Jul 3, 2019
2602fa7
to
ba88311
Compare
simonhong
reviewed
Jul 4, 2019
browser/ui/toolbar/brave_location_bar_model_delegate_unittest.cc
Outdated
Show resolved
Hide resolved
7a5a72f
to
fbd6e09
Compare
bridiver
reviewed
Jul 5, 2019
bridiver
reviewed
Jul 5, 2019
8578999
to
ca8baaa
Compare
bridiver
reviewed
Jul 8, 2019
bridiver
reviewed
Jul 8, 2019
bridiver
reviewed
Jul 8, 2019
bridiver
reviewed
Jul 8, 2019
bridiver
reviewed
Jul 8, 2019
bridiver
reviewed
Jul 8, 2019
bridiver
reviewed
Jul 8, 2019
bridiver
reviewed
Jul 8, 2019
bridiver
reviewed
Jul 8, 2019
browser/ui/toolbar/brave_location_bar_model_delegate_unittest.cc
Outdated
Show resolved
Hide resolved
1f543ea
to
0ca29fe
Compare
bridiver
previously approved these changes
Jul 8, 2019
To avoid a possible race condition with Adding the component and also so that the extension is only downloaded when accessing brave://wallet
0ca29fe
to
7bee0bc
Compare
Passes on CI for both official and unofficial build types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#5117
Fix brave/brave-browser#5118
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.