Button styles #2778
Merged
Button styles #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossmoody
force-pushed
the
paper-styles
branch
2 times, most recently
from
4a804fa to
fc6a3b4
Compare
|
Think all the comments on the original PR are addressed for this one. Sorry for the mixup on PRs. Gonna rebase now. |
fixes paper styles
bsclifton
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Works beautifully! 😄
I did notice this didn't work on the Web Torrent page- but that might be a separate issue (if we don't already have an issue, can you create one @rossmoody?)
STR:
- grab this branch
- visit magnet:?xt=urn:btih:dd8255ecdc7ca55fb0bbf81323d87062db1f6d1c&dn=Big+Buck+Bunny&tr=udp%3A%2F%2Fexplodie.org%3A6969&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969&tr=udp%3A%2F%2Ftracker.empire-js.us%3A1337&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337&tr=wss%3A%2F%2Ftracker.btorrent.xyz&tr=wss%3A%2F%2Ftracker.fastcast.nz&tr=wss%3A%2F%2Ftracker.openwebtorrent.com&ws=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2F&xs=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2Fbig-buck-bunny.torrent
- Check styles on buttons
|
I think I actually have some insight there. Those buttons in webtorrent are tied to Brave UI. I'll post a followup issue for Brave UI button focus state specifically. |
This was referenced Aug 29, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force push mistake, did a reflog. Original PR: #2669
Fixes: brave/brave-browser#3633
Fixes: brave/brave-browser#4852
Before
After
Test Plan:
The buttons effected by these style updates live in