Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ParameterName presubmit rule severity to error #26794

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

AlexeyBarabash
Copy link
Contributor

This PR changes ParameterName presubmit rule severity to error

Resolves brave/brave-browser#42583

This PR was created by two steps:

  1. at tools/android/checkstyle/brave-style-5.0.xml change ParameterName rule to the one from upstream
    <module name="ParameterName">
      <property name="format" value="^(unused_)?[a-z][a-zA-Z0-9]*$"/>
      <property name="severity" value="error"/>
    </module>
  1. run npm run presubmit -- --files *.java and fix all errors

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A, the build should be compiled.

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash AlexeyBarabash force-pushed the presubmit_warnings_to_errors_part2 branch from 0e6179f to a596fb4 Compare November 29, 2024 16:17
@AlexeyBarabash AlexeyBarabash force-pushed the presubmit_warnings_to_errors_part2 branch from a596fb4 to 2bae29a Compare December 6, 2024 15:14
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexeyBarabash AlexeyBarabash merged commit ba0c0ee into master Dec 6, 2024
18 checks passed
@AlexeyBarabash AlexeyBarabash deleted the presubmit_warnings_to_errors_part2 branch December 6, 2024 18:09
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 6, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Change severity level to error for ParameterName presubmit check
4 participants