-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Background Settings for New Tabs Page #2668
Conversation
1d9e64d
to
adeb572
Compare
d89101b
to
97caf99
Compare
97caf99
to
76bc024
Compare
Note: dark mode implementation will be removed from the scope of this PR as there is some additional discussion to be done around that for our web-ui pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ nice work!
Some issues that may be good to solve before this hits release:
|
Feature: brave/brave-browser#4523
Sister PR to brave/brave-ui#485 which was merged and reverted.
Sister PR to brave/brave-ui#491 (brave-ui)
close brave/brave-browser#4523
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.