Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement staging environment support for Android Ads #2660

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 11, 2019

Fixes brave/brave-browser#4799

Submitter Checklist:

Test Plan:

Confirm --brave-ads-staging works on desktop and Rewards staging is working as expected on Android Ads build

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

}

#if defined(OS_ANDROID)
void AdsServiceImpl::UpdateIsProductionFlag() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this could all be done with just the single function, unless there are other reasons for splitting it out like this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that originally and due to #if etc. the code was harder to read

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, gotcha.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually this code should be abstracted out of the ads service, this changed was mainly to add support for Android Ads

@tmancey tmancey requested a review from emerick June 11, 2019 14:34
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 0e1600a into master Jun 11, 2019
@tmancey tmancey deleted the issues/4799 branch June 11, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement staging environment support for Android Ads
2 participants