Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ads not shown if a background tab is playing video #2575

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 3, 2019

Fixes brave/brave-browser#3779

Submitter Checklist:

Test Plan:

  • Test that Ads are shown if media is playing on a non-active (blurred) tab
  • Test that Ads are not shown if media is playing on the active (focused) tab

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 0.68.x - Nightly milestone Jun 3, 2019
@tmancey tmancey self-assigned this Jun 3, 2019
@tmancey tmancey requested review from emerick and NejcZdovc June 3, 2019 10:52
@tmancey tmancey marked this pull request as ready for review June 3, 2019 10:55
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads not shown if a background tab is playing video
2 participants