-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): Enhanced Transaction Submission Status Panels #25470
feat(wallet): Enhanced Transaction Submission Status Panels #25470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++ with a nit.
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
d7c46da
to
8b7d10f
Compare
[puLL-Merge] - brave/brave-core@25470 DescriptionThis PR introduces significant changes to the Brave Wallet UI, particularly in the post-confirmation flow for transactions. It updates the visual design, adds new functionality, and improves the user experience for various transaction states (submitted, signed, completed, failed, or canceled). ChangesChanges
These changes represent a comprehensive update to the transaction confirmation and status UI in the Brave Wallet, introducing new visual elements, more detailed status information, and improved user interactions for various transaction states. Possible Issues
Security HotspotsNone identified. The changes appear to be primarily UI-related and don't introduce any obvious security concerns. |
8b7d10f
to
c1b4301
Compare
c1b4301
to
896d742
Compare
Description
Introduces new and enhanced
Transaction Submission Status
panelsResolves brave/brave-browser#40373
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Screen.Recording.4.mov
Send:
Swap:
Bridge:
ERC20 Approve: