Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Brave Wallet buildflag, menu item #2496

Merged
merged 2 commits into from
May 29, 2019
Merged

Adding Brave Wallet buildflag, menu item #2496

merged 2 commits into from
May 29, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented May 24, 2019

Resolves: brave/brave-browser#4578
Resolves: brave/brave-browser#4579

Screen Shot 2019-05-24 at 12 15 03 PM

Submitter Checklist:

Test Plan:

  1. Confirm that the menu item is not shown in official builds
  2. Confirm that clicking on the menu item opens a new tab to chrome://wallet
  3. Do a test of the other menu items to ensure functionality is preserved.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 0.67.x - Nightly milestone May 24, 2019
@ryanml ryanml requested a review from bbondy May 24, 2019 19:23
@ryanml ryanml self-assigned this May 24, 2019
@ryanml ryanml requested a review from NejcZdovc May 28, 2019 18:22
@ryanml ryanml requested a review from bbondy May 29, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a menu item for triggering WebUI for the Ethereum wallet Add a feature flag for enabling Ethereum wallet
5 participants