Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables show ntp at startup flag on Android #24513

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Jul 4, 2024

Resolves brave/brave-browser#38635
Upstream enabled that flag by default on cr125 chromium/chromium@9e656e9

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I don't have exact steps, but usually it happens when you leave your browser for a long time(overnight)

@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jul 4, 2024
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jul 4, 2024
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner July 4, 2024 19:09
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SergeyZhukovsky SergeyZhukovsky merged commit d3be7c3 into master Jul 5, 2024
20 checks passed
@SergeyZhukovsky SergeyZhukovsky deleted the android_disable_ntp_at_startup branch July 5, 2024 12:49
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 5, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.69.91 Chromium: 127.0.6533.26 (Official Build) canary (64-bit)
--- | ---
Revision | c2e8b99455d26e792d29296a2f6dc7e1b80d913b
OS | Android 15; Build/AP31.240517.031; 35; REL

Prerequisites: For the following verification, I basically opened ~30 tabs (including several tab groups) and left Brave active on a random opened tab. After a certain amount of time, re-opened Brave and ensured that the correct tab is still active.

  • re-opened after ~2hrs and ensured that the correct active tab is still active/selected when restoring
  • re-opened after ~4hrs and ensured that the correct active tab is still active/selected when restoring
  • re-opened after ~8hrs and ensured that the correct active tab is still active/selected when restoring
  • re-opened after ~16hrs and ensured that the correct active tab is still active/selected when restoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android]New tab is added automatically when launching the app
4 participants