Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated default search provider for IT #23406

Merged
merged 1 commit into from
May 3, 2024
Merged

Updated default search provider for IT #23406

merged 1 commit into from
May 3, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 3, 2024 •
edited
Loading

fix brave/brave-browser#38028

Screenshot 2024-05-03 at 13 57 16

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

BraveTemplateURLPrepopulateDataTest.DefaultSearchProvidersForItaly

See the linked issue for manual test.

@simonhong simonhong self-assigned this May 3, 2024
@simonhong simonhong marked this pull request as ready for review May 3, 2024 05:58
@simonhong simonhong requested a review from a team as a code owner May 3, 2024 05:58
@simonhong simonhong requested review from bsclifton and deeppandya May 3, 2024 05:58
@simonhong simonhong merged commit 57cebb6 into master May 3, 2024
20 checks passed
@simonhong simonhong deleted the update_default_search_it branch May 3, 2024 12:14
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone May 3, 2024
@brave-builds brave-builds mentioned this pull request May 7, 2024
Merged
7 tasks
@LaurenWags
Copy link
Member

LaurenWags commented May 7, 2024 •
edited
Loading

Verified with

Brave	1.67.72 Chromium: 125.0.6422.26 (Official Build) nightly (arm64) 
Revision	9f204d486f58a098f9687464150e24df0bb2160e
OS	macOS Version 14.5 (Build 23F5074a)

IT (Italy) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
Screenshot 2024-05-07 at 12 57 57 Screenshot 2024-05-07 at 13 00 34 Screenshot 2024-05-07 at 13 00 44 Screenshot 2024-05-07 at 13 00 52 Screenshot 2024-05-07 at 13 01 22
Updated Profile (Google/Brave) - PASSED
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.67.72 Chromium: 125.0.6422.26 and ensured that Google is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.72 Chromium: 125.0.6422.26
Screenshot 2024-05-07 at 13 12 41 Screenshot 2024-05-07 at 13 13 27
Screenshot 2024-05-07 at 13 12 48 Screenshot 2024-05-07 at 13 13 36
Updated Profile (DDG/Startpage) - PASSED
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to DDG under brave://settings/searchEngines for Normal windows
  • changed the default SE to Startpage under brave://settings/searchEngines for Private windows
  • updated to 1.67.72 Chromium: 125.0.6422.26
  • ensured that DDG wasn't replaced with Brave as the default SE for Normal windows
  • ensured that Startpage wasn't replaced with Brave as the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.72 Chromium: 125.0.6422.26
Screenshot 2024-05-07 at 13 24 34 Screenshot 2024-05-07 at 13 25 44
Screenshot 2024-05-07 at 13 24 52 Screenshot 2024-05-07 at 13 25 52
Screenshot 2024-05-07 at 13 24 59 Screenshot 2024-05-07 at 13 26 01

US (United States) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
Screenshot 2024-05-07 at 1 45 07 PM Screenshot 2024-05-07 at 1 45 17 PM Screenshot 2024-05-07 at 1 45 24 PM Screenshot 2024-05-07 at 1 46 12 PM Screenshot 2024-05-07 at 1 46 25 PM
Updated Profile (Brave/Brave) - PASSED
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.67.72 Chromium: 125.0.6422.26
  • ensured that Brave is still the default SE for both Normal & Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.72 Chromium: 125.0.6422.26
Screenshot 2024-05-07 at 1 51 31 PM Screenshot 2024-05-07 at 1 52 22 PM
Screenshot 2024-05-07 at 1 51 37 PM Screenshot 2024-05-07 at 1 52 28 PM
Screenshot 2024-05-07 at 1 51 43 PM Screenshot 2024-05-07 at 1 52 35 PM
Updated Profile (Ecosia/Bing) - PASSED
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to Ecosia under brave://settings/searchEngines for Normal windows
  • changed the default SE to Bing under brave://settings/searchEngines for Private windows
  • updated to 1.67.72 Chromium: 125.0.6422.26
  • ensured that Ecosia wasn't replaced with Brave as the default SE for Normal windows
  • ensured that Bing wasn't replaced with Brave as the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.72 Chromium: 125.0.6422.26
Screenshot 2024-05-07 at 2 19 20 PM Screenshot 2024-05-07 at 2 20 19 PM
Screenshot 2024-05-07 at 2 19 27 PM Screenshot 2024-05-07 at 2 20 27 PM
Screenshot 2024-05-07 at 2 19 33 PM Screenshot 2024-05-07 at 2 20 35 PM

IN (India) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
Screenshot 2024-05-07 at 2 27 34 PM Screenshot 2024-05-07 at 2 28 04 PM Screenshot 2024-05-07 at 2 28 10 PM Screenshot 2024-05-07 at 2 28 18 PM Screenshot 2024-05-07 at 2 28 28 PM
Updated Profile (Brave/Brave) - PASSED
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.67.72 Chromium: 125.0.6422.26
  • ensured that Brave is still the default SE for both Normal & Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.72 Chromium: 125.0.6422.26
Screenshot 2024-05-07 at 2 48 21 PM Screenshot 2024-05-07 at 2 50 28 PM
Screenshot 2024-05-07 at 2 49 31 PM Screenshot 2024-05-07 at 2 50 36 PM
Screenshot 2024-05-07 at 2 49 50 PM Screenshot 2024-05-07 at 2 50 42 PM
Updated Profile (Qwant/DDG) - PASSED
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to Qwant under brave://settings/searchEngines for Normal windows
  • changed the default SE to DDG under brave://settings/searchEngines for Private windows
  • updated to 1.67.72 Chromium: 125.0.6422.26
  • ensured that Qwant wasn't replaced with Brave as the default SE for Normal windows
  • ensured that DDG wasn't replaced with Brave as the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.72 Chromium: 125.0.6422.26
Screenshot 2024-05-07 at 2 56 18 PM Screenshot 2024-05-07 at 2 56 50 PM
Screenshot 2024-05-07 at 2 56 24 PM Screenshot 2024-05-07 at 2 56 56 PM
Screenshot 2024-05-07 at 2 56 30 PM Screenshot 2024-05-07 at 2 57 02 PM

CN (Mainland China) locale

Clean Profile - PASSED
  • ensured that Google was selected as the default for Normal windows via brave://settings/search
  • ensured that Brave was selected as the default for Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Google was selected as the default via brave://settings/searchEngines
  • ensured that Brave was listed first via brave://settings/searchEngines
Example Example Example Example Example
Screenshot 2024-05-07 at 15 03 14 Screenshot 2024-05-07 at 15 03 53 Screenshot 2024-05-07 at 15 03 59 Screenshot 2024-05-07 at 15 04 06 Screenshot 2024-05-07 at 15 04 14
Updated Profile (Google/Brave) - PASSED
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.67.72 Chromium: 125.0.6422.26 and ensured that Google is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.72 Chromium: 125.0.6422.26
Screenshot 2024-05-07 at 15 07 34 Screenshot 2024-05-07 at 15 08 07
Screenshot 2024-05-07 at 15 07 41 Screenshot 2024-05-07 at 15 08 13
Screenshot 2024-05-07 at 15 07 47 Screenshot 2024-05-07 at 15 08 20
Updated Profile (Startpage/Google) - PASSED
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to Startpage under brave://settings/searchEngines for Normal windows
  • changed the default SE to Google under brave://settings/searchEngines for Private windows
  • updated to 1.67.72 Chromium: 125.0.6422.26
  • ensured that Startpage wasn't replaced with Brave as the default SE for Normal windows
  • ensured that Google wasn't replaced with Brave as the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.72 Chromium: 125.0.6422.26
Screenshot 2024-05-07 at 15 13 20 Screenshot 2024-05-07 at 15 13 54
Screenshot 2024-05-07 at 15 13 25 Screenshot 2024-05-07 at 15 14 00
Screenshot 2024-05-07 at 15 13 31 Screenshot 2024-05-07 at 15 14 06

@kjozwiak
Copy link
Member

kjozwiak commented May 7, 2024 •
edited
Loading

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.67.73 Chromium: 125.0.6422.26 (Official Build) nightly (64-bit)
-- | --
Revision | 76e7d97680074902ad7bde84f0a1a6c392a4ca6a
OS | Windows 11 Version 23H2 (Build 22631.3447)

IT (Italy) locale - PASSED

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
clean1 clean2 clean3
Updated Profile (Google/Brave)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.67.73 Chromium: 125.0.6422.26 and ensured that Google is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.73 Chromium: 125.0.6422.26
googlebefore1 googleafter1
googlebefore2 googleafter2
Updated Profile (DDG/Startpage)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to DDG under brave://settings/searchEngines for Normal windows
  • changed the default SE to Startpage under brave://settings/searchEngines for Private windows
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that DDG wasn't replaced with Brave as the default SE for Normal windows
  • ensured that Startpage wasn't replaced with Brave as the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.73 Chromium: 125.0.6422.26
before1 after1
before2 after2
before3 after3

CA (Canada) locale - PASSED

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
clean1 clean2 clean3
Updated Profile (Brave/Brave)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that Brave is still the default SE for both Normal & Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.73 Chromium: 125.0.6422.26
before1 after1
before2 after2
before3 after3
Updated Profile (Bing/Qwant)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to Bing under brave://settings/searchEngines for Normal windows
  • changed the default SE to Qwant under brave://settings/searchEngines for Private windows
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that Microsoft Bing wasn't replaced with Brave as the default SE for Normal windows
  • ensured that Qwant wasn't replaced with Brave as the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.73 Chromium: 125.0.6422.26
bqBefore1 bqAfter1
bqBefore2 bqAfter2
bqBefore3 bqAfter3

DE (Germany) locale - PASSED

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
clean1 clean2 clean3
Updated Profile (Brave/Brave)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that Brave is still the default SE for both Normal & Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.73 Chromium: 125.0.6422.26
before1 after1
before2 after2
before3 after3
Updated Profile (Ecosia/DDG)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to Ecosia under brave://settings/searchEngines for Normal windows
  • changed the default SE to DDG under brave://settings/searchEngines for Private windows
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that Ecosia wasn't replaced with Brave as the default SE for Normal windows
  • ensured that DDG wasn't replaced with Brave as the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.73 Chromium: 125.0.6422.26
edBefore1 edAfter1
edBefore2 edAfter2
edBefore3 edAfter3

PL (Poland) locale - PASSED

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
clean1 clean2 clean3
Updated Profile (Google/Brave)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.67.73 Chromium: 125.0.6422.26 and ensured that Google is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.73 Chromium: 125.0.6422.26
before1 after1
before2 after2
before3 after3
Updated Profile (Ecosia/DDG)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to Startpage under brave://settings/searchEngines for Normal windows
  • changed the default SE to Bing under brave://settings/searchEngines for Private windows
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that Startpage wasn't replaced with Brave as the default SE for Normal windows
  • ensured that Microsoft Bing wasn't replaced with Brave as the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.67.64 Chromium: 124.0.6367.118 1.67.73 Chromium: 125.0.6422.26
sbbefore1 sbafter1
sbbefore2 sbafter2
sbbefore3 sbafter3

@kjozwiak
Copy link
Member

kjozwiak commented May 7, 2024 •
edited
Loading

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.67.74 Chromium: 125.0.6422.26 (Official Build) canary (64-bit)
--- | ---
Revision | 8abe16ff01716bd4851b1dcc432ec3c662d121c9
OS | Android 14; Build/AP21.240305.005; 34; REL

IT (Italy) locale - PASSED

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via Settings -> Search engines
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
Example Example Example
Screenshot_20240507-155611 Screenshot_20240507-155615 Screenshot_20240507-155620
Updated Profile (Google/Google)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Google was the default SE selected under Settings -> Search engines for Standard Tab
  • ensured that Google was the default SE selected under Settings -> Search engines for Private Tab
  • updated to 1.67.73 Chromium: 125.0.6422.26 and ensured that Google is still the default for Standard & Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.67.64 Chromium: 124.0.6367.118 1.67.74 Chromium: 125.0.6422.26
Screenshot_20240507-155710 Screenshot_20240507-155759
Screenshot_20240507-155713 Screenshot_20240507-155803
Screenshot_20240507-155722 Screenshot_20240507-155808
Updated Profile (DDG/Qwant)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to DDG under Settings -> Search engines for Standard Tab
  • changed the default SE to Qwant under Settings -> Search engines for Private Tab
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that DDG wasn't replaced with Brave as the default SE for Standard Tab
  • ensured that Qwant wasn't replaced with Brave as the default SE for Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.67.64 Chromium: 124.0.6367.118 1.67.74 Chromium: 125.0.6422.26
Screenshot_20240507-155956 Screenshot_20240507-155920
Screenshot_20240507-155924 Screenshot_20240507-155959
Screenshot_20240507-155928 Screenshot_20240507-160004

FR (France) locale - PASSED

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via Settings -> Search engines
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
Example Example Example
Screenshot_20240508-213837 Screenshot_20240508-213840 Screenshot_20240508-213845
Updated Profile (Brave/Brave)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Brave was the default SE selected under Settings -> Search engines for Standard Tab
  • ensured that Brave was the default SE selected under Settings -> Search engines for Private Tab
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that Brave is still the default SE for both Standard Tab & Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.67.64 Chromium: 124.0.6367.118 1.67.74 Chromium: 125.0.6422.26
Screenshot_20240508-214158 Screenshot_20240508-214250
Screenshot_20240508-214204 Screenshot_20240508-214253
Screenshot_20240508-214208 Screenshot_20240508-214259
Updated Profile (DDG/Ecosia)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to DDG under Settings -> Search engines for Standard Tab
  • changed the default SE to Ecosia under Settings -> Search engines for Private Tab
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that DDG wasn't replaced with Brave as the default SE for Standard Tab
  • ensured that Ecosia wasn't replaced with Brave as the default SE for Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.67.64 Chromium: 124.0.6367.118 1.67.74 Chromium: 125.0.6422.26
Screenshot_20240508-225008 Screenshot_20240508-225110
Screenshot_20240508-225012 Screenshot_20240508-225118
Screenshot_20240508-225016 Screenshot_20240508-225122

RO (Rromania) locale - PASSED

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via Settings -> Search engines
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
Example Example Example
Screenshot_20240508-230334 Screenshot_20240508-230337 Screenshot_20240508-230341
Updated Profile (Google/Google)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • ensured that Google was the default SE selected under Settings -> Search engines for Standard Tab
  • ensured that Google was the default SE selected under Settings -> Search engines for Private Tab
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that Google is still the default SE for both Standard Tab & Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.67.64 Chromium: 124.0.6367.118 1.67.74 Chromium: 125.0.6422.26
Screenshot_20240508-225848 Screenshot_20240508-230033
Screenshot_20240508-225852 Screenshot_20240508-230036
Screenshot_20240508-225855 Screenshot_20240508-230039
Updated Profile (DDG/Ecosia)
  • installed 1.67.64 Chromium: 124.0.6367.118
  • changed the default SE to DDG under Settings -> Search engines for Standard Tab
  • changed the default SE to Ecosia under Settings -> Search engines for Private Tab
  • updated to 1.67.73 Chromium: 125.0.6422.26
  • ensured that DDG wasn't replaced with Brave as the default SE for Standard Tab
  • ensured that Ecosia wasn't replaced with Brave as the default SE for Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.67.64 Chromium: 124.0.6367.118 1.67.74 Chromium: 125.0.6422.26
Screenshot_20240508-230626 Screenshot_20240508-230707
Screenshot_20240508-230637 Screenshot_20240508-230709
Screenshot_20240508-230641 Screenshot_20240508-230713

Created brave/brave-browser#38179 which is a C125 bug and will need to be fixed for 1.66.x

@kjozwiak kjozwiak mentioned this pull request May 8, 2024
Closed
simonhong pushed a commit that referenced this pull request May 8, 2024
@brave-builds @simonhong
Uplift of #23406 (squashed) to beta
23ef1b9
kjozwiak pushed a commit that referenced this pull request May 9, 2024
@brave-builds
Updated default search provider for IT (uplift to 1.66.x) (#23444)
797b5ce 
Uplift of #23406 (squashed) to beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iefremov iefremov iefremov approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

@deeppandya deeppandya Awaiting requested review from deeppandya

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging this pull request may close these issues.

Update search engine default for Italy (IT)
4 participants
@simonhong @LaurenWags @kjozwiak @iefremov