Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when vertical tabs are displayed with certain themes (uplift to 1.59.x) #20514

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix crash when vertical tabs are displayed with certain themes (uplift to 1.59.x) #20514

merged 1 commit into from
Oct 13, 2023

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Oct 13, 2023 •
edited by kjozwiak
Loading

Uplift of #20508
Resolves brave/brave-browser#33598

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@zenparsing zenparsing requested a review from a team as a code owner October 13, 2023 00:22
@kjozwiak kjozwiak added this to the 1.59.x - Release #2 milestone Oct 13, 2023
kjozwiak
kjozwiak approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.59.x approved 👍 QA has verified the PR on Nightly as per QA has verified the PR(s) on Nightly as per #20508 (comment).

@kjozwiak kjozwiak merged commit 4281c7f into 1.59.x Oct 13, 2023
@kjozwiak kjozwiak deleted the ksmith-vtab-theme-fix-1.59 branch October 13, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@zenparsing zenparsing

Labels
None yet
Projects
None yet
Milestone
1.59.x - Release #2
Development

Successfully merging this pull request may close these issues.
2 participants
@zenparsing @kjozwiak