WebUI: Remove title for History page pre-load UI #2019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
previously approved these changes
Mar 21, 2019
|
Thanks! |
|
NOTE: will be pushing a rebase (testing locally) 😄 |
bsclifton
force-pushed
the
fix-webui-history-preload
branch
from
2f702c8 to
458592b
Compare
bsclifton
requested changes
Mar 21, 2019
There was a problem hiding this comment.
ugh - of course this changed with Chromium 74 (which was just merged 😂)
I'd save this patch for 0.63.x which is still on Chromium 73. But can you update this to work with the updated filename in C74? Should be src/chrome/browser/resources/history/history.html
|
dev will be updated after a day or two of bake time to 74 as well btw. |
|
Closing in favor of #1909 which will achieve this goal via css |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @bbondy , this is a quick fix to get a smoother transition on the Navigation Bar between pages. We would also like to visit a nicer solution via static HTML to encourage the renderer to 'cache' the UI layer across page navigations, though this likely won't happen between the different 'host' URL contexts of the different WebUIs.
Fix brave/brave-browser#3826
This should be uplifted to wherever the Navigation Bar landed (#1422), which is 0.63.x
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
On brave/brave-browser#3826
Reviewer Checklist: