Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes payments reference #1723

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fixes payments reference #1723

merged 1 commit into from
Feb 20, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 19, 2019 •
edited by jasonrsadler
Loading

Resolves brave/brave-browser#3286

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • start browser with reconcile stamp set to 10min
  • make sure that insufficient funds notification says rewards and not payments

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Feb 19, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 19, 2019
@NejcZdovc NejcZdovc merged commit 9ffaf67 into master Feb 20, 2019
@NejcZdovc NejcZdovc deleted the insufficent-text branch February 20, 2019 06:14
NejcZdovc added a commit that referenced this pull request Feb 20, 2019
@NejcZdovc
Merge pull request #1723 from brave/insufficent-text
889518c 
Fixes payments reference
@NejcZdovc NejcZdovc mentioned this pull request Feb 20, 2019
Merged
@btlechowski btlechowski mentioned this pull request Mar 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrsadler jasonrsadler jasonrsadler approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.63.x - Release
Development

Successfully merging this pull request may close these issues.

Insufficient Funds notification text needs update
2 participants
@NejcZdovc @jasonrsadler