Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dismiss wallet interact notification on newtab for window.open #14009

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

qamarngr
Copy link
Contributor

@qamarngr qamarngr commented Jun 29, 2022

Resolves brave/brave-browser#23745

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This is rare scenario but we can generate this scenario by using following repo
https://github.com/bbondy/eth-manual-tests
and add following change in request.html after Check console for results of clicks.

<br>
    <a href="javascript:{request('eth_requestAccounts'); window.open('test').focus();}">eth_requestAccounts with New Tab</a>

Screenrecorder-2022-06-29-21-19-00-509.mp4

@qamarngr qamarngr added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 29, 2022
@qamarngr qamarngr added this to the 1.42.x - Nightly milestone Jun 29, 2022
@qamarngr qamarngr self-assigned this Jun 29, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@qamarngr qamarngr merged commit 5fedb7c into master Jun 29, 2022
@qamarngr qamarngr deleted the dismiss-wallet-interact-notif-newtab branch June 29, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dismiss wallet interact notification when its not related to tab in focus
3 participants