Resolve vpn support #13851
Merged
Resolve vpn support #13851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
added
CI/skip-linux
CI/skip-macos-x64
| @@ -90,7 +90,7 @@ public void onCheckedChanged(RadioGroup group, int checkedId) { | |||
| @Override | |||
| public void onClick(View v) { | |||
| StringBuilder bodyText = new StringBuilder( | |||
| "\n\n\n\n\n#### Please do not edit any information below ####\n"); | |||
| "\n\n\n\n\n#### Brave doesn’t track you or know how you use our app, so we don’t know how you’ve set up VPN. Please share info about the issue you’re experiencing and we’ll do our best to resolve it as soon as we can. ####\n"); | |||
There was a problem hiding this comment.
shouldn't that string be translated?
There was a problem hiding this comment.
same as other strings below
deeppandya
force-pushed
the
resolve_support_page
branch
from
dc2acf4 to
a51d9d5
Compare
|
CI failing because of https://bravesoftware.slack.com/archives/C7VLGSR55/p1655492899957409 |
deeppandya
force-pushed
the
resolve_support_page
branch
from
a51d9d5 to
691ecad
Compare
This was referenced Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#23490
Resolves brave/brave-browser#23492
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: