Fix pending tips processing for verified Rewards profiles #13609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#20090
Resolves brave/brave-browser#19982
In the current implementation, the pending tips processor will attempt to process records that are added while it is running. This can lead to an infinite (async) loop in the case of external wallet funded contributions. This change implements a minimal solution, where the start time of the process is recorded and compared to the
added_date
value of pending tip entries. Pending tips that are added after the "processor start time" are skipped.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
http://github.com/miyayes
(a Gemini-verified creator in staging).brave://rewards
and view the list of pending tips.brave://rewards
and view the list of pending tips.publisher_info_db
.pending_contribution
table.publisher_id
field value to the publisher ID of a publisher that is verified on a matching external wallet provider.laurenwags.github.io
.laurenwags.github.io
), opening the Rewards panel, and pressing "Refresh".brave://rewards
and verify that the pending tip has been sent.