Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] news crash and orientation issue fixed #13297

Merged
merged 1 commit into from
May 12, 2022

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#22777

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 11, 2022
@tapanmodh tapanmodh added this to the 1.40.x - Nightly milestone May 11, 2022
@tapanmodh tapanmodh self-assigned this May 11, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tapanmodh tapanmodh merged commit b441690 into master May 12, 2022
@tapanmodh tapanmodh deleted the android_news_orientation_fix branch May 12, 2022 04:50
brave-builds pushed a commit that referenced this pull request May 12, 2022
brave-builds pushed a commit that referenced this pull request May 12, 2022
@kjozwiak
Copy link
Member

kjozwiak commented May 12, 2022

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.40.53 Chromium: 101.0.4951.64 (Official Build) canary (32-bit)
--- | ---
Revision | d1daa9897e1bc1d507d6be8f2346e377e5505905-refs/branch-heads/4951@{#1208}
OS | Android 12; Build/SP1A.210812.016

Test Case #1 - brave/brave-browser#22777 (Brave News enabled and then disabled)

Went through the original STR/Cases via brave/brave-browser#22777 (comment) and ensured that Brave wasn't crashing. Also ensured that the NTP isn't scrollable via both portrait or landscape modes.

Test Case #2 - Upgrading from 1.39.67 Chromium: 101.0.4951.34 when Brave News was never enabled

  • download/install 1.39.67 Chromium: 101.0.4951.34 and skip through all the onboarding
  • ensure that you've never enabled Brave News and close Brave (while the NTP is active)
  • update to 1.40.53 Chromium: 101.0.4951.64 and open Brave
  • ensured the opt-in card is visible and that scrolling while in portrait or landscape mode didn't cause crashes
  • ensured there's no issues enabling Brave News via the opt-in card via NTP

Test Case #3 - Upgrading from 1.39.67 Chromium: 101.0.4951.34 when Brave News has been enabled

  • download/install 1.39.67 Chromium: 101.0.4951.34 and skip through all the onboarding
  • ensure that you've enabled Brave News and scroll through the feed
  • close Brave and update to 1.40.53 Chromium: 101.0.4951.64
  • ensure that Brave News is still enabled and you can scroll through the feed without any issues
  • ensured that scrolling through the news feed via portrait or landscape mode doesn't cause any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
4 participants