Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes users are not served ads due to failure to initialize Brave Ads when migrating to database schema 21 or above - 1.38.x #13186

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fixes users are not served ads due to failure to initialize Brave Ads when migrating to database schema 21 or above - 1.38.x #13186

merged 1 commit into from
Apr 28, 2022

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 27, 2022 •
edited by kjozwiak
Loading

Uplift of #13164
Resolves brave/brave-browser#22540

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey
Fixes users are not served ads due to failure to initialize Brave Ads…
9814994 
… when migrating to database schema 21 or above
@tmancey tmancey requested a review from a team April 27, 2022 13:20
@tmancey tmancey requested a review from a team as a code owner April 27, 2022 13:20
@tmancey tmancey self-assigned this Apr 27, 2022
@tmancey tmancey removed the request for review from a team April 27, 2022 13:20
@tmancey tmancey added this to the 1.38.x - Release #2 milestone Apr 27, 2022
kjozwiak
kjozwiak approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #13164 (comment).

@kjozwiak kjozwiak merged commit f932e38 into 1.38.x Apr 28, 2022
@kjozwiak kjozwiak deleted the issues/22540-1.38.x branch April 28, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.38.x - Release #6
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @kjozwiak @LaurenWags