Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove need for brave-browser repo #13006

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

mihaiplesa
Copy link
Collaborator

@mihaiplesa mihaiplesa commented Apr 13, 2022

For https://github.com/brave/devops/issues/6502

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mihaiplesa mihaiplesa self-assigned this Apr 13, 2022
@github-actions github-actions bot removed the rebase label Apr 13, 2022
@mihaiplesa mihaiplesa added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 13, 2022
@mihaiplesa mihaiplesa force-pushed the mplesa-remove-brave-browser branch from 7f25ae1 to f4cdc6e Compare April 13, 2022 22:39
@mihaiplesa mihaiplesa marked this pull request as ready for review April 13, 2022 22:39
@mihaiplesa mihaiplesa requested review from a team, bsclifton and bridiver as code owners April 13, 2022 22:39
@mihaiplesa mihaiplesa added CI/skip Do not run CI builds (except noplatform) rebase and removed CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 13, 2022
@mihaiplesa mihaiplesa changed the title Mplesa remove brave browser remove need for brave-browser repo Apr 13, 2022
@mihaiplesa mihaiplesa requested a review from petemill April 13, 2022 22:48
@github-actions github-actions bot removed the rebase label Apr 13, 2022
@mihaiplesa mihaiplesa added this to the 1.39.x - Nightly milestone Apr 14, 2022
@mihaiplesa
Copy link
Collaborator Author

This is ready to go and has been tested separately, please review.

Jenkinsfile Show resolved Hide resolved
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be great to test this out! Changes look good 😄

@mihaiplesa mihaiplesa force-pushed the mplesa-remove-brave-browser branch from f4cdc6e to 07ef5cd Compare April 14, 2022 19:22
@mihaiplesa mihaiplesa requested a review from bridiver April 14, 2022 19:23
@mihaiplesa mihaiplesa merged commit ebb3f14 into master Apr 15, 2022
@mihaiplesa mihaiplesa deleted the mplesa-remove-brave-browser branch April 15, 2022 22:47
@mihaiplesa mihaiplesa restored the mplesa-remove-brave-browser branch April 15, 2022 22:47
@mihaiplesa mihaiplesa deleted the mplesa-remove-brave-browser branch April 15, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants