Fix performance of cosmetic filters

[atuchin-m]

For brave/brave-browser#22030
1.37.5 => good

1.37.6 => bad

Try to revert #12038 that makes cosmetic filters slower.

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

See brave/brave-browser#22030 (comment)

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[SergeyZhukovsky]

@atuchin-m nice find. Need perhaps to polish and profile more what @antonok-edm did before we can re-merge it back.

[SergeyZhukovsky]

we have also reports on Android that 1.37.x is slower comparing to 1.36.x

[SergeyZhukovsky]

need to fix a few tests before merge, but otherwise looks good

[antonok-edm]

AdBlockServiceTest.CosmeticFilteringOverridesImportant will have to be disabled as well, that was the primary issue fixed by the original PR

[atuchin-m]

@antonok-edm also CosmeticFilteringDynamicCustom doesn't work. Is it expected?

[antonok-edm]

Yeah, unfortunately it looks like I inserted two different fixes into the same PR. If you un-revert the changes in CosmeticFilteringDynamicCustom and in test/data/cosmetic_filtering.html, I think that one should work fine.

[atuchin-m]

In fact it's not enough..

[55080:56304:0411/175238.315:INFO:CONSOLE(5)] "still waiting for css selector", source: __const_std::string&_script__ (5)
content/public/test/browser_test_utils.cc(2659): error: Failed
RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content/public/test/browser_test_base.cc:809.

[antonok-edm]

I just pushed a couple of fixes for that as well.

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[antonok-edm]

macOS CI failures are known/unrelated

[kjozwiak]

Reproduced the original issue on Win 11 x64 using the STR/Cases outlined via brave/brave-browser#22030 (comment) with the following build:

Brave | 1.39.47 Chromium: 100.0.4896.79 (Official Build) nightly (64-bit)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 11 Version 21H2 (Build 22000.593)

• Shields disabled - ~250ms - 300ms
• Shields enabled - ~850ms - 1s

Shields Disabled	Shields Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.39.52 Chromium: 100.0.4896.88 (Official Build) nightly (64-bit)
-- | --
Revision | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS | Windows 11 Version 21H2 (Build 22000.593)

• Shields disabled - ~250ms - 300ms
• Shields enabled - ~300ms - 385ms

Shields Disabled	Shields Enabled

[atuchin-m]

It should be >=1.39.49, 48 doesn't have the fix:

[kjozwiak]

It should be >=1.39.49, 48 doesn't have the fix:

yup, used 1.39.52 Chromium: 100.0.4896.88 👍 It was technically supposed to be in 1.39.48 but looks like that used to basically bump the tags. Finished verifying and updated the above notes.