Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Brave news - disables default peeking card #12489

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented Mar 4, 2022

Resolves brave/brave-browser#21477

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 4, 2022
@alexsafe alexsafe added this to the 1.38.x - Nightly milestone Mar 4, 2022
@alexsafe alexsafe self-assigned this Mar 4, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

kjozwiak commented Mar 6, 2022

Verification PASSED on Pixel 6 running Android 12 using 1.38.25 Chromium: 99.0.4884.51

Clean Install Case

  • ensured that Brave News is disabled by default and the on-boarding card isn't visible under NTP
  • ensured that you can't scroll up/down via NTP when Brave News is disabled
  • ensured that you can swipe through the widgets without running into Fast/Hard scroll on widgets brings up the news feed rather than scrolling through the widget brave-browser#21166
  • ensured that enabling Brave News via Hamburger Menu -> Brave News displays the on-boarding card via NTP but doesn't automatically enable Brave News and starts loading the feed.
  • ensure that tapping on Show Brave News via NTP/on-boarding card works as expected and loads the feed without issues

Created brave/brave-browser#21493.

Upgrade Case - Card visible but not opted into Brave News

  • downloaded/installed 1.38.24 Chromium: 99.0.4844.51 and ensured that the Brave News on-boarding card is visible
  • updated to 1.38.25 Chromium: 99.0.4884.51 and ensured that the Brave News card has been disabled from NTP
  • ensured that enable Brave News via Settings displays the on-boarding card via NTP
  • ensure that tapping on Show Brave News loads the feed via NTP without any issues after enabling the on-boarding card

Upgrade Case - Enabled/Opted into Brave News

  • downloaded/installed 1.38.24 Chromium: 99.0.4844.51 and enabled Brave News
  • removed/unchecked all the sources from Cars
  • enabled all the available sources via Business
  • updated to 1.38.25 Chromium: 99.0.4884.51 and ensured Brave News was still enabled
  • ensured that all the sources under Business are still enabled and all the sources via Cars are disabled
  • ensured that tapping on cards/settings works as expected (basically making sure Brave News is still working)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable default peeking card
4 participants