Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct appguid for darwin when uploading to Omaha #1211

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Use correct appguid for darwin when uploading to Omaha #1211

merged 1 commit into from
Jan 4, 2019

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Jan 4, 2019

Fixes: brave/brave-browser#2790

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mbacchi mbacchi added the 0.60.x label Jan 4, 2019
@mbacchi mbacchi requested review from bbondy and mihaiplesa January 4, 2019 15:22
mihaiplesa
mihaiplesa approved these changes Jan 4, 2019
View reviewed changes
Copy link
Collaborator

@mihaiplesa mihaiplesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@bbondy bbondy merged commit 9d80d5b into 0.60.x Jan 4, 2019
@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
@bsclifton bsclifton deleted the appguid-0.60.x branch January 24, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa mihaiplesa approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.60.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mbacchi @mihaiplesa @bbondy