Use correct appguid for darwin when uploading to Omaha #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes brave/brave-browser#2790 |
bbondy
requested changes
Jan 2, 2019
script/lib/omaha.py
Outdated
| @@ -71,7 +71,7 @@ def get_base64_authorization(omahaid, omahapw): | |||
|
|
|||
| # To-Do: Add functions to create apps | |||
| def get_appguid(channel, platform): | |||
| if channel in 'dev' or channel in 'release' and platform in 'darwin': | |||
| if channel in 'dev' or platform in 'darwin' and channel in ['beta', 'dev', 'release']: | |||
There was a problem hiding this comment.
I think maybe you mean:
if channel in ['dev'] or platform in ['darwin'] and channel in ['beta', 'dev', 'release']:
Otherwise for example 'e' is in 'dev'
There was a problem hiding this comment.
or by using == like channel == 'dev'
There was a problem hiding this comment.
Fixed that if statement. Thanks!
There was a problem hiding this comment.
I guess I can't resolve a change request by you @bbondy. Do you mind resolving it so I can merge?
brave-browser-releases
previously approved these changes
Jan 3, 2019
bbondy
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: