Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove instagram igshid params #11616

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Conversation

pes10k
Copy link
Contributor

@pes10k pes10k commented Dec 15, 2021

Resolves brave/brave-browser#11580

Removes the instagram igshid query parameter to our existing "strip query parameters" feature.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open https://www.instagram.com/p/CDtn9hcAYpm/?igshid=1bjglumson2t5.
  2. Check the URL bar to make sure that the igshid=... parameter has been removed.

@pes10k pes10k requested a review from iefremov as a code owner December 15, 2021 20:23
@pes10k pes10k requested a review from fmarier December 15, 2021 20:23
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Dec 15, 2021
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss the Instagram tracker, but the Marketo one is unfortunately tangled with their auth system.

@pes10k pes10k force-pushed the remove-more-ig-and-adobe-tracking-params branch from 332abdc to 731a162 Compare December 16, 2021 19:59
@pes10k pes10k changed the title remove adobe mkt_tok and instagram igshid params remove instagram igshid params Dec 16, 2021
@pes10k
Copy link
Contributor Author

pes10k commented Dec 17, 2021

Confirmed with @linhkikuchi that the failure on MacOS is unrelated to the change here, and that the PR should be treated as "all tests passing"

https://bravesoftware.slack.com/archives/CA5FPHWLF/p1639709440050400?thread_ts=1639704987.042300&cid=CA5FPHWLF

@pes10k pes10k merged commit 92bef25 into master Dec 17, 2021
@pes10k pes10k deleted the remove-more-ig-and-adobe-tracking-params branch December 17, 2021 05:05
@pes10k pes10k added this to the 1.35.x - Nightly milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out Instagram's tracker from URLs
3 participants