Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismiss all errors at sync start #1152

Merged
merged 1 commit into from
Dec 20, 2018
Merged

dismiss all errors at sync start #1152

merged 1 commit into from
Dec 20, 2018

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#2484

Test Plan:

  1. Disconnect device from network
  2. Open brave://bravesync and click on Enter a sync chain code
  3. Click Confirm Sync code, shows error message
  4. Close browser without dismissing the popup notification
  5. Restart browser and open sync page and click on Enter a sync chain code. No message should be shown
  6. Click Confirm Sync code, shows error message as expected

@cezaraugusto cezaraugusto self-assigned this Dec 19, 2018
@cezaraugusto cezaraugusto requested review from darkdh and removed request for darkdh December 19, 2018 21:50
@cezaraugusto cezaraugusto requested a review from darkdh December 19, 2018 22:02
@cezaraugusto cezaraugusto merged commit 5992ca7 into master Dec 20, 2018
@cezaraugusto cezaraugusto deleted the ca-2484 branch December 20, 2018 01:49
cezaraugusto added a commit that referenced this pull request Dec 20, 2018
@cezaraugusto
Merge pull request #1152 from brave/ca-2484
4050a66 
dismiss all errors at sync start
@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Dec 20, 2018 •
edited by darkdh
Loading

master 5992ca7
0.60.x 4050a66
0.59.x 5a598b4

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

darkdh pushed a commit that referenced this pull request Dec 20, 2018
@cezaraugusto @darkdh
Merge pull request #1152 from brave/ca-2484
5a598b4 
dismiss all errors at sync start
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Jan 2, 2019
Closed
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.

Error message isn't dismissed when browser is closed
4 participants
@cezaraugusto @rebron @darkdh @bbondy