Disable navigator.keyboard API when fingerprinting protection is on. #10935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
force-pushed
the
maxk-disable-navigator-keyboard
branch
from
f4623ae to
c56a710
Compare
|
Yeah I don't have any experience conditionally removing an IDL-defined API at runtime. I'm sure it's technically feasible, but this is probably sufficient. If we get webcompat reports, we can revisit. |
iefremov
reviewed
Nov 12, 2021
| #include "chrome/test/base/in_process_browser_test.h" | ||
| #include "chrome/test/base/ui_test_utils.h" | ||
| #include "components/network_session_configurator/common/network_switches.h" | ||
| #include "components/permissions/permission_request.h" |
There was a problem hiding this comment.
unused? Pls check for unused includes
There was a problem hiding this comment.
Removed in 0dfc2a8
iefremov
approved these changes
Nov 12, 2021
|
|
||
| using brave_shields::ControlType; | ||
|
|
||
| const char kGetLayoutMapScript[] = |
There was a problem hiding this comment.
could be constexpr and also raw string literarls are handier
There was a problem hiding this comment.
Changed in 0dfc2a8. Also changed the script itself as it was failing on Windows CI with
15:11:59 ../../brave/browser/farbling/brave_navigator_keyboard_api_browsertest.cc(116): error: Expected equality of these values: 15:11:59 15:11:59 "a" 15:11:59 15:11:59 Which is: 00007FF7741DC7BD 15:11:59 15:11:59 EvalJs(contents(), kGetLayoutMapScript) 15:11:59 15:11:59 Which is: null
Assuming, because there's no physical keyboard?
| void SetUpCommandLine(base::CommandLine* command_line) override { | ||
| // HTTPS server only serves a valid cert for localhost, so this is needed | ||
| // to load pages from other hosts without an error | ||
| command_line->AppendSwitch(switches::kIgnoreCertificateErrors); |
There was a problem hiding this comment.
better avoid this (as per annoucement on slack)
Fixes brave/brave-browser#3964 Have not found a convenient way to return navigator.keyboard as undefined yet, so for now making it a null. Since this API is not supported by all browsers making an assumption that web developers would check the API availability before using it in the form of `if (navigator.keyboard)...`, in which case a null should work just as well.
mkarolin
force-pushed
the
maxk-disable-navigator-keyboard
branch
from
c56a710 to
0dfc2a8
Compare
goodov
approved these changes
Nov 16, 2021
| #include "chrome/common/chrome_content_client.h" | ||
| #include "chrome/test/base/in_process_browser_test.h" | ||
| #include "chrome/test/base/ui_test_utils.h" | ||
| #include "components/network_session_configurator/common/network_switches.h" |
There was a problem hiding this comment.
Doh! Removed in 2653b6b
|
|
||
| using brave_shields::ControlType; | ||
|
|
||
| constexpr char kGetLayoutMapScript[] = |
…ting protection is on.
mkarolin
force-pushed
the
maxk-disable-navigator-keyboard
branch
from
0dfc2a8 to
2653b6b
Compare
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3964
Have not found a convenient way to return navigator.keyboard as
undefinedyet, so for now making it a null.Since this API is not supported by all browsers making an assumption
that web developers would check the API availability before using it
in the form of
if (navigator.keyboard)..., in which case a nullshould work just as well.
Maybe @pilgrim-brave or @bridiver have a better idea on making it
undefined.Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: